Button: support <input> tag wrapped in <label> tag. Fix #6063, Button doesn't support radio input inside label.#531
Closed
pjw91 wants to merge 2 commits intojquery:masterfrom
Closed
Button: support <input> tag wrapped in <label> tag. Fix #6063, Button doesn't support radio input inside label.#531pjw91 wants to merge 2 commits intojquery:masterfrom
pjw91 wants to merge 2 commits intojquery:masterfrom
Conversation
Signed-off-by: mail6543210 <mail6543210@yahoo.com.tw>
Author
|
Actually I'm not really sure how does the unit-test work, I just guess and edit the button.html. |
|
I did some other approach for the same bug: I just updated the _determineButtonType to check for parents, and if matched just temporary detached the input from DOM. #777 And for unit test: I don't know either, but just after a quick look: maybe it requires a '#6063' test case in https://github.com/jquery/jquery-ui/blob/master/tests/unit/button/button_tickets.js too? |
Member
|
Thanks for the patch, but reviewing the underlying ticket we closed it as wontfix, see @jzaefferer's comment there: http://bugs.jqueryui.com/ticket/6063#comment:13 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.